From 3eeb9f6d2687a6866202111175041dccfb78bfd1 Mon Sep 17 00:00:00 2001 From: Huxley Date: Wed, 29 Apr 2026 11:50:09 +0800 Subject: [PATCH] Implement JWT authentication and app passkey support - Add JWT token generation and validation - Implement bcrypt password hashing - Create auth service with register/login/refresh/logout - Add app passkey generation and management - Implement protected routes and auth middleware - Add comprehensive tests for new functionality --- docs/architecture.md | 7 +- docs/roadmap.md | 18 +- go.mod | 4 +- internal/app/webapp.go | 62 ++-- internal/app/webapp_test.go | 4 +- internal/auth/jwt.go | 61 ++++ internal/auth/jwt_test.go | 93 ++++++ internal/auth/password.go | 26 ++ internal/auth/password_test.go | 48 ++++ internal/auth/token.go | 30 ++ internal/auth/token_test.go | 59 ++++ internal/handler/auth.go | 189 ++++++++++++ internal/handler/auth_test.go | 325 +++++++++++++++++++++ internal/middleware/auth.go | 52 ++++ internal/middleware/auth_test.go | 139 +++++++++ internal/model/credential.go | 18 ++ internal/repository/credential.go | 101 +++++++ internal/repository/credential_test.go | 194 +++++++++++++ internal/repository/db.go | 1 + internal/server/routes_protected.go | 22 +- internal/server/routes_public.go | 9 + internal/server/server_test.go | 12 +- internal/service/auth.go | 243 ++++++++++++++++ internal/service/auth_test.go | 382 +++++++++++++++++++++++++ 24 files changed, 2063 insertions(+), 36 deletions(-) create mode 100644 internal/auth/jwt.go create mode 100644 internal/auth/jwt_test.go create mode 100644 internal/auth/password.go create mode 100644 internal/auth/password_test.go create mode 100644 internal/auth/token.go create mode 100644 internal/auth/token_test.go create mode 100644 internal/handler/auth.go create mode 100644 internal/handler/auth_test.go create mode 100644 internal/middleware/auth.go create mode 100644 internal/middleware/auth_test.go create mode 100644 internal/model/credential.go create mode 100644 internal/repository/credential.go create mode 100644 internal/repository/credential_test.go create mode 100644 internal/service/auth.go create mode 100644 internal/service/auth_test.go diff --git a/docs/architecture.md b/docs/architecture.md index 9495e69..d4e4e7e 100644 --- a/docs/architecture.md +++ b/docs/architecture.md @@ -46,9 +46,12 @@ GET /api/v1/version POST /api/v1/auth/register POST /api/v1/auth/login POST /api/v1/auth/refresh +POST /api/v1/auth/logout -GET /api/v1/users/me -PATCH /api/v1/users/me +GET /api/v1/account +GET /api/v1/account/passkeys +POST /api/v1/account/passkeys +DELETE /api/v1/account/passkeys/:id GET /api/v1/files POST /api/v1/files diff --git a/docs/roadmap.md b/docs/roadmap.md index c49dd4d..4da8342 100644 --- a/docs/roadmap.md +++ b/docs/roadmap.md @@ -4,9 +4,9 @@ | Feature | Status | Notes | |---------|--------|-------| -| CLI config management | 🛠 WIP | | -| JWT authentication | 🛠 WIP | access + refresh tokens, refresh token in DB | -| Web API foundation | 🛠 WIP | WebApp composition, Gin router, graceful shutdown, `GET /api/v1/version` | +| CLI config management | ✅ | | +| JWT authentication | ✅ | access + refresh tokens, refresh token in DB, app passkey support | +| Web API foundation | ✅ | WebApp composition, Gin router, graceful shutdown, `GET /api/v1/version` | | File upload/download/manage APIs | 🛠 WIP | REST API via Gin | | Admin endpoints | 🛠 WIP | user CRUD for superusers | | WebDAV | 🛠 WIP | future v0 or v1 | @@ -19,14 +19,14 @@ Package-level implementation order (each task includes unit tests): 2. `internal/app` — runtime dependency container ✅ 3. `internal/model` — domain types, error codes ✅ 4. `internal/api` — error response helpers ✅ -5. `internal/auth` — JWT utils +5. `internal/auth` — JWT utils ✅ 6. `internal/storage` — backend interface + local fs 7. `internal/repository` — interfaces + GORM/SQLite impl ✅ -8. `internal/service` — auth, file, admin services -9. `internal/middleware` — logger, cors, auth -10. `internal/handler` — auth, file, admin handlers 🛠 WIP -11. `internal/server` — Gin router, route registration, graceful shutdown 🛠 WIP -12. `cmd/serve.go`, `cmd/config.go`, `cmd/status.go` 🛠 WIP +8. `internal/service` — auth, file, admin services ✅ (auth done) +9. `internal/middleware` — logger, cors, auth ✅ (auth done) +10. `internal/handler` — auth, file, admin handlers ✅ (auth done) +11. `internal/server` — Gin router, route registration, graceful shutdown ✅ +12. `cmd/serve.go`, `cmd/config.go`, `cmd/status.go` ✅ (serve done) 13. Integration tests ## Future diff --git a/go.mod b/go.mod index d544ffc..69cb763 100644 --- a/go.mod +++ b/go.mod @@ -4,8 +4,11 @@ go 1.26.2 require ( github.com/gin-gonic/gin v1.12.0 + github.com/golang-jwt/jwt/v5 v5.3.1 + github.com/google/uuid v1.6.0 github.com/spf13/cobra v1.10.2 github.com/spf13/viper v1.21.0 + golang.org/x/crypto v0.48.0 gorm.io/driver/postgres v1.6.0 gorm.io/driver/sqlite v1.6.0 gorm.io/gorm v1.30.5 @@ -53,7 +56,6 @@ require ( go.mongodb.org/mongo-driver/v2 v2.5.0 // indirect go.yaml.in/yaml/v3 v3.0.4 // indirect golang.org/x/arch v0.22.0 // indirect - golang.org/x/crypto v0.48.0 // indirect golang.org/x/net v0.51.0 // indirect golang.org/x/sync v0.19.0 // indirect golang.org/x/sys v0.41.0 // indirect diff --git a/internal/app/webapp.go b/internal/app/webapp.go index 4bab6eb..a2886f0 100644 --- a/internal/app/webapp.go +++ b/internal/app/webapp.go @@ -7,6 +7,7 @@ import ( "github.com/dhao2001/mygo/internal/config" "github.com/dhao2001/mygo/internal/repository" + "github.com/dhao2001/mygo/internal/service" ) // WebApp contains application-wide runtime dependencies and metadata. @@ -14,14 +15,16 @@ type WebApp struct { Config *config.Config Version string - DB *gorm.DB - UserRepo repository.UserRepository - SessionRepo repository.SessionRepository - FileRepo repository.FileRepository + DB *gorm.DB + UserRepo repository.UserRepository + SessionRepo repository.SessionRepository + FileRepo repository.FileRepository + CredentialRepo repository.CredentialRepository + AuthService *service.AuthService } // Bootstrap creates a fully initialized WebApp from config. -// It opens the database, runs migrations, and wires all repositories. +// It opens the database, runs migrations, and wires all repositories and services. func Bootstrap(cfg *config.Config) (*WebApp, error) { db, err := repository.Open(cfg.Database) if err != nil { @@ -32,25 +35,48 @@ func Bootstrap(cfg *config.Config) (*WebApp, error) { return nil, fmt.Errorf("migrate database: %w", err) } + userRepo := repository.NewUserRepository(db) + sessionRepo := repository.NewSessionRepository(db) + fileRepo := repository.NewFileRepository(db) + credentialRepo := repository.NewCredentialRepository(db) + + jwtSecret := []byte(cfg.JWT.Secret) + authService := service.NewAuthService( + userRepo, sessionRepo, credentialRepo, + jwtSecret, + cfg.JWT.AccessDuration(), + cfg.JWT.RefreshDuration(), + ) + return &WebApp{ - Config: cfg, - Version: AppVersion, - DB: db, - UserRepo: repository.NewUserRepository(db), - SessionRepo: repository.NewSessionRepository(db), - FileRepo: repository.NewFileRepository(db), + Config: cfg, + Version: AppVersion, + DB: db, + UserRepo: userRepo, + SessionRepo: sessionRepo, + FileRepo: fileRepo, + CredentialRepo: credentialRepo, + AuthService: authService, }, nil } // NewWebApp creates a WebApp with pre-built dependencies (useful for testing). -func NewWebApp(cfg *config.Config, db *gorm.DB, userRepo repository.UserRepository, sessionRepo repository.SessionRepository, fileRepo repository.FileRepository) *WebApp { +func NewWebApp(cfg *config.Config, db *gorm.DB, + userRepo repository.UserRepository, + sessionRepo repository.SessionRepository, + fileRepo repository.FileRepository, + credentialRepo repository.CredentialRepository, + authService *service.AuthService, +) *WebApp { return &WebApp{ - Config: cfg, - Version: AppVersion, - DB: db, - UserRepo: userRepo, - SessionRepo: sessionRepo, - FileRepo: fileRepo, + Config: cfg, + Version: AppVersion, + DB: db, + UserRepo: userRepo, + SessionRepo: sessionRepo, + FileRepo: fileRepo, + CredentialRepo: credentialRepo, + AuthService: authService, } } diff --git a/internal/app/webapp_test.go b/internal/app/webapp_test.go index 4999ba2..03f8c87 100644 --- a/internal/app/webapp_test.go +++ b/internal/app/webapp_test.go @@ -9,7 +9,7 @@ import ( func TestNewWebApp(t *testing.T) { cfg := &config.Config{} - webApp := NewWebApp(cfg, nil, nil, nil, nil) + webApp := NewWebApp(cfg, nil, nil, nil, nil, nil, nil) if webApp.Config != cfg { t.Fatal("Config was not assigned") @@ -20,7 +20,7 @@ func TestNewWebApp(t *testing.T) { } func TestCloseNilDB(t *testing.T) { - webApp := NewWebApp(&config.Config{}, nil, nil, nil, nil) + webApp := NewWebApp(&config.Config{}, nil, nil, nil, nil, nil, nil) if err := webApp.Close(); err != nil { t.Errorf("Close with nil DB should not error: %v", err) } diff --git a/internal/auth/jwt.go b/internal/auth/jwt.go new file mode 100644 index 0000000..b5c6c2c --- /dev/null +++ b/internal/auth/jwt.go @@ -0,0 +1,61 @@ +package auth + +import ( + "fmt" + "time" + + "github.com/golang-jwt/jwt/v5" + "github.com/google/uuid" +) + +// Claims represents the JWT claims for MyGO access tokens. +type Claims struct { + jwt.RegisteredClaims + UserID string `json:"uid"` +} + +// GenerateAccessToken creates a signed JWT access token for a user. +func GenerateAccessToken(userID string, secret []byte, ttl time.Duration) (string, error) { + now := time.Now() + claims := Claims{ + RegisteredClaims: jwt.RegisteredClaims{ + ID: uuid.NewString(), + IssuedAt: jwt.NewNumericDate(now), + ExpiresAt: jwt.NewNumericDate(now.Add(ttl)), + }, + UserID: userID, + } + + token := jwt.NewWithClaims(jwt.SigningMethodHS256, claims) + signed, err := token.SignedString(secret) + if err != nil { + return "", fmt.Errorf("sign token: %w", err) + } + + return signed, nil +} + +// GenerateRefreshToken creates a signed JWT refresh token. +func GenerateRefreshToken(userID string, secret []byte, ttl time.Duration) (string, error) { + return GenerateAccessToken(userID, secret, ttl) +} + +// ParseToken validates and parses a JWT token string. +func ParseToken(tokenString string, secret []byte) (*Claims, error) { + token, err := jwt.ParseWithClaims(tokenString, &Claims{}, func(t *jwt.Token) (any, error) { + if _, ok := t.Method.(*jwt.SigningMethodHMAC); !ok { + return nil, fmt.Errorf("unexpected signing method: %v", t.Header["alg"]) + } + return secret, nil + }) + if err != nil { + return nil, fmt.Errorf("parse token: %w", err) + } + + claims, ok := token.Claims.(*Claims) + if !ok || !token.Valid { + return nil, fmt.Errorf("invalid token claims") + } + + return claims, nil +} diff --git a/internal/auth/jwt_test.go b/internal/auth/jwt_test.go new file mode 100644 index 0000000..5cf3573 --- /dev/null +++ b/internal/auth/jwt_test.go @@ -0,0 +1,93 @@ +package auth + +import ( + "strings" + "testing" + "time" +) + +func TestGenerateAccessToken(t *testing.T) { + secret := []byte("test-secret") + token, err := GenerateAccessToken("user-1", secret, 15*time.Minute) + if err != nil { + t.Fatalf("GenerateAccessToken = %v", err) + } + if token == "" { + t.Fatal("token is empty") + } + if !strings.Contains(token, ".") { + t.Fatal("token does not look like a JWT") + } +} + +func TestParseTokenValid(t *testing.T) { + secret := []byte("test-secret") + token, err := GenerateAccessToken("user-1", secret, 15*time.Minute) + if err != nil { + t.Fatalf("GenerateAccessToken = %v", err) + } + + claims, err := ParseToken(token, secret) + if err != nil { + t.Fatalf("ParseToken = %v", err) + } + if claims.UserID != "user-1" { + t.Errorf("UserID = %q, want %q", claims.UserID, "user-1") + } +} + +func TestParseTokenWrongSecret(t *testing.T) { + secret := []byte("test-secret") + token, err := GenerateAccessToken("user-1", secret, 15*time.Minute) + if err != nil { + t.Fatalf("GenerateAccessToken = %v", err) + } + + _, err = ParseToken(token, []byte("wrong-secret")) + if err == nil { + t.Fatal("expected error for wrong secret, got nil") + } +} + +func TestParseTokenExpired(t *testing.T) { + secret := []byte("test-secret") + token, err := GenerateAccessToken("user-1", secret, -1*time.Minute) + if err != nil { + t.Fatalf("GenerateAccessToken = %v", err) + } + + _, err = ParseToken(token, secret) + if err == nil { + t.Fatal("expected error for expired token, got nil") + } +} + +func TestParseTokenInvalidFormat(t *testing.T) { + _, err := ParseToken("not-a-jwt", []byte("secret")) + if err == nil { + t.Fatal("expected error for invalid format, got nil") + } +} + +func TestGenerateRefreshToken(t *testing.T) { + secret := []byte("test-secret") + token, err := GenerateRefreshToken("user-1", secret, 7*24*time.Hour) + if err != nil { + t.Fatalf("GenerateRefreshToken = %v", err) + } + if token == "" { + t.Fatal("token is empty") + } +} + +func TestTokenUserIDCarried(t *testing.T) { + secret := []byte("test-secret") + token, _ := GenerateAccessToken("alice-42", secret, 15*time.Minute) + claims, err := ParseToken(token, secret) + if err != nil { + t.Fatalf("ParseToken = %v", err) + } + if claims.UserID != "alice-42" { + t.Errorf("UserID = %q, want %q", claims.UserID, "alice-42") + } +} diff --git a/internal/auth/password.go b/internal/auth/password.go new file mode 100644 index 0000000..5210fd7 --- /dev/null +++ b/internal/auth/password.go @@ -0,0 +1,26 @@ +package auth + +import ( + "fmt" + + "golang.org/x/crypto/bcrypt" +) + +const bcryptCost = 12 + +// HashPassword returns a bcrypt hash of the plaintext password. +func HashPassword(password string) (string, error) { + hash, err := bcrypt.GenerateFromPassword([]byte(password), bcryptCost) + if err != nil { + return "", fmt.Errorf("hash password: %w", err) + } + return string(hash), nil +} + +// VerifyPassword compares a bcrypt hash with a plaintext password. +func VerifyPassword(hash, password string) error { + if err := bcrypt.CompareHashAndPassword([]byte(hash), []byte(password)); err != nil { + return fmt.Errorf("invalid password") + } + return nil +} diff --git a/internal/auth/password_test.go b/internal/auth/password_test.go new file mode 100644 index 0000000..74fe9aa --- /dev/null +++ b/internal/auth/password_test.go @@ -0,0 +1,48 @@ +package auth + +import ( + "testing" +) + +func TestHashPassword(t *testing.T) { + hash, err := HashPassword("mypassword") + if err != nil { + t.Fatalf("HashPassword = %v", err) + } + if hash == "" { + t.Fatal("hash is empty") + } + if hash == "mypassword" { + t.Fatal("hash should not equal the plaintext password") + } +} + +func TestVerifyPasswordCorrect(t *testing.T) { + hash, err := HashPassword("mypassword") + if err != nil { + t.Fatalf("HashPassword = %v", err) + } + + if err := VerifyPassword(hash, "mypassword"); err != nil { + t.Fatalf("VerifyPassword = %v", err) + } +} + +func TestVerifyPasswordWrong(t *testing.T) { + hash, err := HashPassword("mypassword") + if err != nil { + t.Fatalf("HashPassword = %v", err) + } + + if err := VerifyPassword(hash, "wrongpassword"); err == nil { + t.Fatal("expected error for wrong password, got nil") + } +} + +func TestHashPasswordUnique(t *testing.T) { + hash1, _ := HashPassword("mypassword") + hash2, _ := HashPassword("mypassword") + if hash1 == hash2 { + t.Fatal("bcrypt should produce different hashes for the same password") + } +} diff --git a/internal/auth/token.go b/internal/auth/token.go new file mode 100644 index 0000000..83a0173 --- /dev/null +++ b/internal/auth/token.go @@ -0,0 +1,30 @@ +package auth + +import ( + "crypto/rand" + "crypto/sha256" + "encoding/hex" + "fmt" +) + +const tokenPrefix = "mygo_" +const tokenByteLen = 24 + +// GenerateToken creates a random token with the "mygo_" prefix. +// Returns the raw token (shown to the user) and its SHA-256 hash (stored in DB). +func GenerateToken() (raw, hash string, err error) { + bytes := make([]byte, tokenByteLen) + if _, err := rand.Read(bytes); err != nil { + return "", "", fmt.Errorf("generate random bytes: %w", err) + } + + raw = tokenPrefix + hex.EncodeToString(bytes) + hash = HashToken(raw) + return raw, hash, nil +} + +// HashToken returns the SHA-256 hex digest of a token. +func HashToken(token string) string { + sum := sha256.Sum256([]byte(token)) + return hex.EncodeToString(sum[:]) +} diff --git a/internal/auth/token_test.go b/internal/auth/token_test.go new file mode 100644 index 0000000..dda69a6 --- /dev/null +++ b/internal/auth/token_test.go @@ -0,0 +1,59 @@ +package auth + +import ( + "strings" + "testing" +) + +func TestGenerateToken(t *testing.T) { + raw, hash, err := GenerateToken() + if err != nil { + t.Fatalf("GenerateToken = %v", err) + } + + if !strings.HasPrefix(raw, tokenPrefix) { + t.Errorf("raw token %q does not start with %q", raw, tokenPrefix) + } + + expectedHash := HashToken(raw) + if hash != expectedHash { + t.Errorf("hash = %q, want %q", hash, expectedHash) + } +} + +func TestGenerateTokenUniqueness(t *testing.T) { + raw1, _, _ := GenerateToken() + raw2, _, _ := GenerateToken() + + if raw1 == raw2 { + t.Fatal("two generated tokens should not be equal") + } +} + +func TestGenerateTokenLength(t *testing.T) { + raw, _, err := GenerateToken() + if err != nil { + t.Fatalf("GenerateToken = %v", err) + } + + expectedLen := len(tokenPrefix) + tokenByteLen*2 // hex encodes each byte as 2 chars + if len(raw) != expectedLen { + t.Errorf("token length = %d, want %d", len(raw), expectedLen) + } +} + +func TestHashTokenDeterministic(t *testing.T) { + hash1 := HashToken("mygo_test_token") + hash2 := HashToken("mygo_test_token") + if hash1 != hash2 { + t.Fatal("HashToken should be deterministic") + } +} + +func TestHashTokenDifferent(t *testing.T) { + hash1 := HashToken("mygo_aaa") + hash2 := HashToken("mygo_bbb") + if hash1 == hash2 { + t.Fatal("different inputs should produce different hashes") + } +} diff --git a/internal/handler/auth.go b/internal/handler/auth.go new file mode 100644 index 0000000..d33ad21 --- /dev/null +++ b/internal/handler/auth.go @@ -0,0 +1,189 @@ +package handler + +import ( + "net/http" + + "github.com/gin-gonic/gin" + + "github.com/dhao2001/mygo/internal/api" + "github.com/dhao2001/mygo/internal/middleware" + "github.com/dhao2001/mygo/internal/model" + "github.com/dhao2001/mygo/internal/service" +) + +// AuthHandler handles authentication endpoints. +type AuthHandler struct { + authService *service.AuthService +} + +// NewAuthHandler creates an AuthHandler. +func NewAuthHandler(authService *service.AuthService) *AuthHandler { + return &AuthHandler{authService: authService} +} + +type registerRequest struct { + Username string `json:"username" binding:"required"` + Email string `json:"email" binding:"required,email"` + Password string `json:"password" binding:"required,min=6"` +} + +type loginRequest struct { + Email string `json:"email" binding:"required,email"` + Password string `json:"password" binding:"required"` +} + +type tokenRequest struct { + RefreshToken string `json:"refresh_token" binding:"required"` +} + +// Register handles POST /api/v1/auth/register. +func (h *AuthHandler) Register(c *gin.Context) { + var req registerRequest + if err := c.ShouldBindJSON(&req); err != nil { + api.Error(c, http.StatusBadRequest, "invalid request: "+err.Error()) + return + } + + user, err := h.authService.Register(c.Request.Context(), req.Username, req.Email, req.Password) + if err != nil { + api.Error(c, http.StatusConflict, err.Error()) + return + } + + c.JSON(http.StatusCreated, user) +} + +// Login handles POST /api/v1/auth/login. +func (h *AuthHandler) Login(c *gin.Context) { + var req loginRequest + if err := c.ShouldBindJSON(&req); err != nil { + api.Error(c, http.StatusBadRequest, "invalid request: "+err.Error()) + return + } + + pair, err := h.authService.Login(c.Request.Context(), req.Email, req.Password) + if err != nil { + api.Error(c, http.StatusUnauthorized, err.Error()) + return + } + + c.JSON(http.StatusOK, pair) +} + +// Refresh handles POST /api/v1/auth/refresh. +func (h *AuthHandler) Refresh(c *gin.Context) { + var req tokenRequest + if err := c.ShouldBindJSON(&req); err != nil { + api.Error(c, http.StatusBadRequest, "invalid request: "+err.Error()) + return + } + + pair, err := h.authService.Refresh(c.Request.Context(), req.RefreshToken) + if err != nil { + api.Error(c, http.StatusUnauthorized, err.Error()) + return + } + + c.JSON(http.StatusOK, pair) +} + +// Logout handles POST /api/v1/auth/logout. +func (h *AuthHandler) Logout(c *gin.Context) { + var req tokenRequest + if err := c.ShouldBindJSON(&req); err != nil { + api.Error(c, http.StatusBadRequest, "invalid request: "+err.Error()) + return + } + + if err := h.authService.Logout(c.Request.Context(), req.RefreshToken); err != nil { + api.Error(c, http.StatusInternalServerError, err.Error()) + return + } + + c.Status(http.StatusOK) +} + +// GetAccount handles GET /api/v1/account. +func (h *AuthHandler) GetAccount(c *gin.Context) { + userID := middleware.GetUserID(c) + if userID == "" { + api.Error(c, http.StatusUnauthorized, "unauthorized") + return + } + + c.JSON(http.StatusOK, gin.H{"user_id": userID}) +} + +type createPasskeyRequest struct { + Label string `json:"label" binding:"required"` +} + +// ListPasskeys handles GET /api/v1/users/me/passkeys. +func (h *AuthHandler) ListPasskeys(c *gin.Context) { + userID := middleware.GetUserID(c) + if userID == "" { + api.Error(c, http.StatusUnauthorized, "unauthorized") + return + } + + creds, err := h.authService.ListPasskeys(c.Request.Context(), userID) + if err != nil { + api.Error(c, http.StatusInternalServerError, err.Error()) + return + } + + if creds == nil { + creds = []model.Credential{} + } + + c.JSON(http.StatusOK, creds) +} + +// CreatePasskey handles POST /api/v1/users/me/passkeys. +func (h *AuthHandler) CreatePasskey(c *gin.Context) { + userID := middleware.GetUserID(c) + if userID == "" { + api.Error(c, http.StatusUnauthorized, "unauthorized") + return + } + + var req createPasskeyRequest + if err := c.ShouldBindJSON(&req); err != nil { + api.Error(c, http.StatusBadRequest, "invalid request: "+err.Error()) + return + } + + pk, err := h.authService.CreatePasskey(c.Request.Context(), userID, req.Label) + if err != nil { + api.Error(c, http.StatusInternalServerError, err.Error()) + return + } + + c.JSON(http.StatusCreated, pk) +} + +// RevokePasskey handles DELETE /api/v1/users/me/passkeys/:id. +func (h *AuthHandler) RevokePasskey(c *gin.Context) { + userID := middleware.GetUserID(c) + if userID == "" { + api.Error(c, http.StatusUnauthorized, "unauthorized") + return + } + + passkeyID := c.Param("id") + if passkeyID == "" { + api.Error(c, http.StatusBadRequest, "missing passkey id") + return + } + + if err := h.authService.RevokePasskey(c.Request.Context(), userID, passkeyID); err != nil { + if err == model.ErrForbidden { + api.Error(c, http.StatusForbidden, err.Error()) + return + } + api.Error(c, http.StatusInternalServerError, err.Error()) + return + } + + c.Status(http.StatusOK) +} diff --git a/internal/handler/auth_test.go b/internal/handler/auth_test.go new file mode 100644 index 0000000..21f47d3 --- /dev/null +++ b/internal/handler/auth_test.go @@ -0,0 +1,325 @@ +package handler + +import ( + "bytes" + "encoding/json" + "net/http" + "net/http/httptest" + "testing" + "time" + + "github.com/gin-gonic/gin" + "gorm.io/driver/sqlite" + "gorm.io/gorm" + + "github.com/dhao2001/mygo/internal/middleware" + "github.com/dhao2001/mygo/internal/model" + "github.com/dhao2001/mygo/internal/repository" + "github.com/dhao2001/mygo/internal/service" +) + +func setupAuthHandler(t *testing.T) (*AuthHandler, []byte) { + t.Helper() + + db, err := gorm.Open(sqlite.Open(":memory:"), &gorm.Config{}) + if err != nil { + t.Fatalf("open db: %v", err) + } + if err := db.AutoMigrate(&model.User{}, &model.Session{}, &model.Credential{}); err != nil { + t.Fatalf("migrate: %v", err) + } + + secret := []byte("test-secret") + authService := service.NewAuthService( + repository.NewUserRepository(db), + repository.NewSessionRepository(db), + repository.NewCredentialRepository(db), + secret, + 15*time.Minute, + 7*24*time.Hour, + ) + + return NewAuthHandler(authService), secret +} + +func setupAuthRouter(t *testing.T) (*gin.Engine, []byte) { + t.Helper() + + handler, secret := setupAuthHandler(t) + + gin.SetMode(gin.TestMode) + r := gin.New() + + auth := r.Group("/api/v1/auth") + { + auth.POST("/register", handler.Register) + auth.POST("/login", handler.Login) + auth.POST("/refresh", handler.Refresh) + auth.POST("/logout", handler.Logout) + } + + protected := r.Group("/api/v1") + protected.Use(middleware.AuthRequired(secret)) + { + account := protected.Group("/account") + { + account.GET("", handler.GetAccount) + + passkeys := account.Group("/passkeys") + { + passkeys.GET("", handler.ListPasskeys) + passkeys.POST("", handler.CreatePasskey) + passkeys.DELETE("/:id", handler.RevokePasskey) + } + } + } + + return r, secret +} + +func TestRegisterHandler(t *testing.T) { + r, _ := setupAuthRouter(t) + + body, _ := json.Marshal(gin.H{ + "username": "alice", + "email": "alice@example.com", + "password": "password123", + }) + + req := httptest.NewRequest(http.MethodPost, "/api/v1/auth/register", bytes.NewReader(body)) + req.Header.Set("Content-Type", "application/json") + rec := httptest.NewRecorder() + r.ServeHTTP(rec, req) + + if rec.Code != http.StatusCreated { + t.Errorf("status = %d, want %d; body = %s", rec.Code, http.StatusCreated, rec.Body.String()) + } +} + +func TestRegisterHandlerDuplicate(t *testing.T) { + r, _ := setupAuthRouter(t) + + body, _ := json.Marshal(gin.H{ + "username": "alice", + "email": "alice@example.com", + "password": "password123", + }) + + for i := range 2 { + req := httptest.NewRequest(http.MethodPost, "/api/v1/auth/register", bytes.NewReader(body)) + req.Header.Set("Content-Type", "application/json") + rec := httptest.NewRecorder() + r.ServeHTTP(rec, req) + + if i == 0 && rec.Code != http.StatusCreated { + t.Fatalf("first register: status = %d", rec.Code) + } + if i == 1 && rec.Code != http.StatusConflict { + t.Errorf("second register: status = %d, want %d", rec.Code, http.StatusConflict) + } + } +} + +func TestLoginHandler(t *testing.T) { + r, _ := setupAuthRouter(t) + + // Register first + body, _ := json.Marshal(gin.H{ + "username": "alice", + "email": "alice@example.com", + "password": "password123", + }) + req := httptest.NewRequest(http.MethodPost, "/api/v1/auth/register", bytes.NewReader(body)) + req.Header.Set("Content-Type", "application/json") + rec := httptest.NewRecorder() + r.ServeHTTP(rec, req) + if rec.Code != http.StatusCreated { + t.Fatalf("register failed: %d", rec.Code) + } + + // Login + loginBody, _ := json.Marshal(gin.H{ + "email": "alice@example.com", + "password": "password123", + }) + req = httptest.NewRequest(http.MethodPost, "/api/v1/auth/login", bytes.NewReader(loginBody)) + req.Header.Set("Content-Type", "application/json") + rec = httptest.NewRecorder() + r.ServeHTTP(rec, req) + + if rec.Code != http.StatusOK { + t.Errorf("status = %d, want %d; body = %s", rec.Code, http.StatusOK, rec.Body.String()) + } + + var pair service.TokenPair + if err := json.Unmarshal(rec.Body.Bytes(), &pair); err != nil { + t.Fatalf("unmarshal response: %v", err) + } + if pair.AccessToken == "" || pair.RefreshToken == "" { + t.Fatal("tokens should not be empty") + } +} + +func TestLoginHandlerWrongPassword(t *testing.T) { + r, _ := setupAuthRouter(t) + + body, _ := json.Marshal(gin.H{ + "username": "alice", + "email": "alice@example.com", + "password": "password123", + }) + req := httptest.NewRequest(http.MethodPost, "/api/v1/auth/register", bytes.NewReader(body)) + req.Header.Set("Content-Type", "application/json") + rec := httptest.NewRecorder() + r.ServeHTTP(rec, req) + + loginBody, _ := json.Marshal(gin.H{ + "email": "alice@example.com", + "password": "wrongpassword", + }) + req = httptest.NewRequest(http.MethodPost, "/api/v1/auth/login", bytes.NewReader(loginBody)) + req.Header.Set("Content-Type", "application/json") + rec = httptest.NewRecorder() + r.ServeHTTP(rec, req) + + if rec.Code != http.StatusUnauthorized { + t.Errorf("status = %d, want %d", rec.Code, http.StatusUnauthorized) + } +} + +func TestRefreshHandler(t *testing.T) { + r, _ := setupAuthRouter(t) + + // Register + Login + body, _ := json.Marshal(gin.H{ + "username": "alice", + "email": "alice@example.com", + "password": "password123", + }) + req := httptest.NewRequest(http.MethodPost, "/api/v1/auth/register", bytes.NewReader(body)) + req.Header.Set("Content-Type", "application/json") + httptest.NewRecorder().Body = nil + rec := httptest.NewRecorder() + r.ServeHTTP(rec, req) + + loginBody, _ := json.Marshal(gin.H{"email": "alice@example.com", "password": "password123"}) + req = httptest.NewRequest(http.MethodPost, "/api/v1/auth/login", bytes.NewReader(loginBody)) + req.Header.Set("Content-Type", "application/json") + rec = httptest.NewRecorder() + r.ServeHTTP(rec, req) + + var pair service.TokenPair + json.Unmarshal(rec.Body.Bytes(), &pair) + + // Refresh + refreshBody, _ := json.Marshal(gin.H{"refresh_token": pair.RefreshToken}) + req = httptest.NewRequest(http.MethodPost, "/api/v1/auth/refresh", bytes.NewReader(refreshBody)) + req.Header.Set("Content-Type", "application/json") + rec = httptest.NewRecorder() + r.ServeHTTP(rec, req) + + if rec.Code != http.StatusOK { + t.Errorf("status = %d, want %d; body = %s", rec.Code, http.StatusOK, rec.Body.String()) + } +} + +func TestAccountEndpoint(t *testing.T) { + r, _ := setupAuthRouter(t) + + // Register + Login + body, _ := json.Marshal(gin.H{"username": "alice", "email": "alice@example.com", "password": "password123"}) + req := httptest.NewRequest(http.MethodPost, "/api/v1/auth/register", bytes.NewReader(body)) + req.Header.Set("Content-Type", "application/json") + rec := httptest.NewRecorder() + r.ServeHTTP(rec, req) + + loginBody, _ := json.Marshal(gin.H{"email": "alice@example.com", "password": "password123"}) + req = httptest.NewRequest(http.MethodPost, "/api/v1/auth/login", bytes.NewReader(loginBody)) + req.Header.Set("Content-Type", "application/json") + rec = httptest.NewRecorder() + r.ServeHTTP(rec, req) + + var pair service.TokenPair + json.Unmarshal(rec.Body.Bytes(), &pair) + + // Get /account + req = httptest.NewRequest(http.MethodGet, "/api/v1/account", nil) + req.Header.Set("Authorization", "Bearer "+pair.AccessToken) + rec = httptest.NewRecorder() + r.ServeHTTP(rec, req) + + if rec.Code != http.StatusOK { + t.Errorf("status = %d, want %d", rec.Code, http.StatusOK) + } +} + +func TestAccountEndpointUnauthorized(t *testing.T) { + r, _ := setupAuthRouter(t) + + req := httptest.NewRequest(http.MethodGet, "/api/v1/account", nil) + rec := httptest.NewRecorder() + r.ServeHTTP(rec, req) + + if rec.Code != http.StatusUnauthorized { + t.Errorf("status = %d, want %d", rec.Code, http.StatusUnauthorized) + } +} + +func TestPasskeyCRUD(t *testing.T) { + r, _ := setupAuthRouter(t) + + // Register + Login + body, _ := json.Marshal(gin.H{"username": "alice", "email": "alice@example.com", "password": "password123"}) + req := httptest.NewRequest(http.MethodPost, "/api/v1/auth/register", bytes.NewReader(body)) + req.Header.Set("Content-Type", "application/json") + rec := httptest.NewRecorder() + r.ServeHTTP(rec, req) + + loginBody, _ := json.Marshal(gin.H{"email": "alice@example.com", "password": "password123"}) + req = httptest.NewRequest(http.MethodPost, "/api/v1/auth/login", bytes.NewReader(loginBody)) + req.Header.Set("Content-Type", "application/json") + rec = httptest.NewRecorder() + r.ServeHTTP(rec, req) + + var pair service.TokenPair + json.Unmarshal(rec.Body.Bytes(), &pair) + authHeader := "Bearer " + pair.AccessToken + + // Create passkey + pkBody, _ := json.Marshal(gin.H{"label": "My Phone"}) + req = httptest.NewRequest(http.MethodPost, "/api/v1/account/passkeys", bytes.NewReader(pkBody)) + req.Header.Set("Content-Type", "application/json") + req.Header.Set("Authorization", authHeader) + rec = httptest.NewRecorder() + r.ServeHTTP(rec, req) + + if rec.Code != http.StatusCreated { + t.Fatalf("create passkey: status = %d, body = %s", rec.Code, rec.Body.String()) + } + + // List passkeys + req = httptest.NewRequest(http.MethodGet, "/api/v1/account/passkeys", nil) + req.Header.Set("Authorization", authHeader) + rec = httptest.NewRecorder() + r.ServeHTTP(rec, req) + + if rec.Code != http.StatusOK { + t.Fatalf("list passkeys: status = %d", rec.Code) + } + + // Revoke passkey + var creds []model.Credential + json.Unmarshal(rec.Body.Bytes(), &creds) + if len(creds) != 1 { + t.Fatalf("expected 1 passkey, got %d", len(creds)) + } + + req = httptest.NewRequest(http.MethodDelete, "/api/v1/account/passkeys/"+creds[0].ID, nil) + req.Header.Set("Authorization", authHeader) + rec = httptest.NewRecorder() + r.ServeHTTP(rec, req) + + if rec.Code != http.StatusOK { + t.Errorf("revoke passkey: status = %d", rec.Code) + } +} diff --git a/internal/middleware/auth.go b/internal/middleware/auth.go new file mode 100644 index 0000000..dbcd903 --- /dev/null +++ b/internal/middleware/auth.go @@ -0,0 +1,52 @@ +package middleware + +import ( + "net/http" + "strings" + + "github.com/gin-gonic/gin" + + "github.com/dhao2001/mygo/internal/api" + "github.com/dhao2001/mygo/internal/auth" +) + +const userIDKey = "user_id" + +// AuthRequired returns a Gin middleware that validates JWT access tokens. +// On success, it injects the user ID into the context via c.Get("user_id"). +func AuthRequired(jwtSecret []byte) gin.HandlerFunc { + return func(c *gin.Context) { + header := c.GetHeader("Authorization") + if header == "" { + api.Error(c, http.StatusUnauthorized, "missing authorization header") + c.Abort() + return + } + + parts := strings.SplitN(header, " ", 2) + if len(parts) != 2 || !strings.EqualFold(parts[0], "bearer") { + api.Error(c, http.StatusUnauthorized, "invalid authorization header format") + c.Abort() + return + } + + claims, err := auth.ParseToken(parts[1], jwtSecret) + if err != nil { + api.Error(c, http.StatusUnauthorized, "invalid or expired token") + c.Abort() + return + } + + c.Set(userIDKey, claims.UserID) + c.Next() + } +} + +// GetUserID extracts the user ID injected by AuthRequired. +func GetUserID(c *gin.Context) string { + v, _ := c.Get(userIDKey) + if v == nil { + return "" + } + return v.(string) +} diff --git a/internal/middleware/auth_test.go b/internal/middleware/auth_test.go new file mode 100644 index 0000000..7c7c242 --- /dev/null +++ b/internal/middleware/auth_test.go @@ -0,0 +1,139 @@ +package middleware + +import ( + "net/http" + "net/http/httptest" + "strings" + "testing" + "time" + + "github.com/gin-gonic/gin" + + "github.com/dhao2001/mygo/internal/auth" +) + +func setupTestRouter(secret []byte) *gin.Engine { + gin.SetMode(gin.TestMode) + r := gin.New() + r.Use(AuthRequired(secret)) + r.GET("/protected", func(c *gin.Context) { + c.JSON(http.StatusOK, gin.H{"user_id": GetUserID(c)}) + }) + return r +} + +func TestAuthRequiredNoHeader(t *testing.T) { + r := setupTestRouter([]byte("test-secret")) + + req := httptest.NewRequest(http.MethodGet, "/protected", nil) + rec := httptest.NewRecorder() + r.ServeHTTP(rec, req) + + if rec.Code != http.StatusUnauthorized { + t.Errorf("status = %d, want %d", rec.Code, http.StatusUnauthorized) + } +} + +func TestAuthRequiredInvalidFormat(t *testing.T) { + r := setupTestRouter([]byte("test-secret")) + + req := httptest.NewRequest(http.MethodGet, "/protected", nil) + req.Header.Set("Authorization", "invalid") + rec := httptest.NewRecorder() + r.ServeHTTP(rec, req) + + if rec.Code != http.StatusUnauthorized { + t.Errorf("status = %d, want %d", rec.Code, http.StatusUnauthorized) + } +} + +func TestAuthRequiredNotBearer(t *testing.T) { + r := setupTestRouter([]byte("test-secret")) + + req := httptest.NewRequest(http.MethodGet, "/protected", nil) + req.Header.Set("Authorization", "Basic dXNlcjpwYXNz") + rec := httptest.NewRecorder() + r.ServeHTTP(rec, req) + + if rec.Code != http.StatusUnauthorized { + t.Errorf("status = %d, want %d", rec.Code, http.StatusUnauthorized) + } +} + +func TestAuthRequiredExpiredToken(t *testing.T) { + secret := []byte("test-secret") + token, err := auth.GenerateAccessToken("user-1", secret, -1*time.Minute) + if err != nil { + t.Fatalf("GenerateAccessToken = %v", err) + } + + r := setupTestRouter(secret) + req := httptest.NewRequest(http.MethodGet, "/protected", nil) + req.Header.Set("Authorization", "Bearer "+token) + rec := httptest.NewRecorder() + r.ServeHTTP(rec, req) + + if rec.Code != http.StatusUnauthorized { + t.Errorf("status = %d, want %d", rec.Code, http.StatusUnauthorized) + } +} + +func TestAuthRequiredValidToken(t *testing.T) { + secret := []byte("test-secret") + token, err := auth.GenerateAccessToken("user-1", secret, 15*time.Minute) + if err != nil { + t.Fatalf("GenerateAccessToken = %v", err) + } + + r := setupTestRouter(secret) + req := httptest.NewRequest(http.MethodGet, "/protected", nil) + req.Header.Set("Authorization", "Bearer "+token) + rec := httptest.NewRecorder() + r.ServeHTTP(rec, req) + + if rec.Code != http.StatusOK { + t.Errorf("status = %d, want %d", rec.Code, http.StatusOK) + } +} + +func TestGetUserID(t *testing.T) { + secret := []byte("test-secret") + token, err := auth.GenerateAccessToken("alice-42", secret, 15*time.Minute) + if err != nil { + t.Fatalf("GenerateAccessToken = %v", err) + } + + r := setupTestRouter(secret) + req := httptest.NewRequest(http.MethodGet, "/protected", nil) + req.Header.Set("Authorization", "Bearer "+token) + rec := httptest.NewRecorder() + r.ServeHTTP(rec, req) + + if rec.Code != http.StatusOK { + t.Fatalf("status = %d", rec.Code) + } + + body := rec.Body.String() + if !strings.Contains(body, "alice-42") { + t.Errorf("response body %q does not contain user id", body) + } +} + +func TestAuthRequiredWrongSecret(t *testing.T) { + secret := []byte("test-secret") + token, err := auth.GenerateAccessToken("user-1", secret, 15*time.Minute) + if err != nil { + t.Fatalf("GenerateAccessToken = %v", err) + } + + // Use a different secret for the middleware + r := setupTestRouter([]byte("different-secret")) + req := httptest.NewRequest(http.MethodGet, "/protected", nil) + req.Header.Set("Authorization", "Bearer "+token) + rec := httptest.NewRecorder() + r.ServeHTTP(rec, req) + + if rec.Code != http.StatusUnauthorized { + t.Errorf("status = %d, want %d", rec.Code, http.StatusUnauthorized) + } +} diff --git a/internal/model/credential.go b/internal/model/credential.go new file mode 100644 index 0000000..9160810 --- /dev/null +++ b/internal/model/credential.go @@ -0,0 +1,18 @@ +package model + +import ( + "time" +) + +// Credential represents an alternative authentication credential for a user. +// The primary password is stored on the User model; additional credentials +// (app passkeys, WebAuthn, OAuth) are stored here with a type discriminator. +type Credential struct { + ID string `gorm:"primaryKey;type:varchar(36)" json:"id"` + UserID string `gorm:"index;type:varchar(36);not null" json:"user_id"` + Type string `gorm:"index;type:varchar(32);not null" json:"type"` + Label string `gorm:"type:varchar(128)" json:"label"` + SecretHash string `gorm:"uniqueIndex;type:varchar(255);not null" json:"-"` + LastUsedAt *time.Time `json:"last_used_at"` + CreatedAt time.Time `json:"created_at"` +} diff --git a/internal/repository/credential.go b/internal/repository/credential.go new file mode 100644 index 0000000..9ef6b6c --- /dev/null +++ b/internal/repository/credential.go @@ -0,0 +1,101 @@ +package repository + +import ( + "context" + "errors" + "time" + + "gorm.io/gorm" + + "github.com/dhao2001/mygo/internal/model" +) + +// CredentialRepository provides access to alternative credential records. +type CredentialRepository interface { + Create(ctx context.Context, cred *model.Credential) error + FindByID(ctx context.Context, id string) (*model.Credential, error) + FindByUserID(ctx context.Context, userID string) ([]model.Credential, error) + FindByUserIDAndType(ctx context.Context, userID, credType string) ([]model.Credential, error) + FindByHash(ctx context.Context, hash string) (*model.Credential, error) + UpdateLastUsed(ctx context.Context, id string) error + Delete(ctx context.Context, id string) error +} + +type credentialRepository struct { + db *gorm.DB +} + +// NewCredentialRepository creates a CredentialRepository backed by GORM. +func NewCredentialRepository(db *gorm.DB) CredentialRepository { + return &credentialRepository{db: db} +} + +func (r *credentialRepository) Create(ctx context.Context, cred *model.Credential) error { + result := r.db.WithContext(ctx).Create(cred) + if result.Error != nil { + if isDuplicateKeyError(result.Error) { + return model.ErrDuplicate + } + return result.Error + } + return nil +} + +func (r *credentialRepository) FindByID(ctx context.Context, id string) (*model.Credential, error) { + var cred model.Credential + result := r.db.WithContext(ctx).First(&cred, "id = ?", id) + if errors.Is(result.Error, gorm.ErrRecordNotFound) { + return nil, model.ErrNotFound + } + if result.Error != nil { + return nil, result.Error + } + return &cred, nil +} + +func (r *credentialRepository) FindByUserID(ctx context.Context, userID string) ([]model.Credential, error) { + var creds []model.Credential + result := r.db.WithContext(ctx).Where("user_id = ?", userID).Find(&creds) + if result.Error != nil { + return nil, result.Error + } + return creds, nil +} + +func (r *credentialRepository) FindByUserIDAndType(ctx context.Context, userID, credType string) ([]model.Credential, error) { + var creds []model.Credential + result := r.db.WithContext(ctx).Where("user_id = ? AND type = ?", userID, credType).Find(&creds) + if result.Error != nil { + return nil, result.Error + } + return creds, nil +} + +func (r *credentialRepository) FindByHash(ctx context.Context, hash string) (*model.Credential, error) { + var cred model.Credential + result := r.db.WithContext(ctx).First(&cred, "secret_hash = ?", hash) + if errors.Is(result.Error, gorm.ErrRecordNotFound) { + return nil, model.ErrNotFound + } + if result.Error != nil { + return nil, result.Error + } + return &cred, nil +} + +func (r *credentialRepository) UpdateLastUsed(ctx context.Context, id string) error { + now := time.Now() + result := r.db.WithContext(ctx).Model(&model.Credential{}).Where("id = ?", id).Update("last_used_at", now) + if result.Error != nil { + return result.Error + } + return nil +} + +func (r *credentialRepository) Delete(ctx context.Context, id string) error { + result := r.db.WithContext(ctx).Delete(&model.Credential{}, "id = ?", id) + if result.Error != nil { + return result.Error + } + return nil +} diff --git a/internal/repository/credential_test.go b/internal/repository/credential_test.go new file mode 100644 index 0000000..e7354f5 --- /dev/null +++ b/internal/repository/credential_test.go @@ -0,0 +1,194 @@ +package repository + +import ( + "context" + "testing" + + "gorm.io/driver/sqlite" + "gorm.io/gorm" + + "github.com/dhao2001/mygo/internal/model" +) + +func setupCredentialRepo(t *testing.T) CredentialRepository { + t.Helper() + + db, err := gorm.Open(sqlite.Open(":memory:"), &gorm.Config{}) + if err != nil { + t.Fatalf("open db: %v", err) + } + if err := db.AutoMigrate(&model.Credential{}); err != nil { + t.Fatalf("migrate: %v", err) + } + + return NewCredentialRepository(db) +} + +func TestCredentialRepository_Create(t *testing.T) { + repo := setupCredentialRepo(t) + ctx := context.Background() + + cred := &model.Credential{ + ID: "cred-1", + UserID: "user-1", + Type: "app_passkey", + Label: "My Phone", + SecretHash: "hash-abc", + } + + if err := repo.Create(ctx, cred); err != nil { + t.Fatalf("Create = %v", err) + } +} + +func TestCredentialRepository_CreateDuplicateHash(t *testing.T) { + repo := setupCredentialRepo(t) + ctx := context.Background() + + c1 := &model.Credential{ID: "cred-1", UserID: "user-1", Type: "app_passkey", Label: "A", SecretHash: "hash-abc"} + c2 := &model.Credential{ID: "cred-2", UserID: "user-1", Type: "app_passkey", Label: "B", SecretHash: "hash-abc"} + + if err := repo.Create(ctx, c1); err != nil { + t.Fatalf("Create = %v", err) + } + + err := repo.Create(ctx, c2) + if err != model.ErrDuplicate { + t.Fatalf("expected ErrDuplicate, got %v", err) + } +} + +func TestCredentialRepository_FindByID(t *testing.T) { + repo := setupCredentialRepo(t) + ctx := context.Background() + + cred := &model.Credential{ID: "cred-1", UserID: "user-1", Type: "app_passkey", Label: "Phone", SecretHash: "h1"} + if err := repo.Create(ctx, cred); err != nil { + t.Fatalf("Create = %v", err) + } + + found, err := repo.FindByID(ctx, "cred-1") + if err != nil { + t.Fatalf("FindByID = %v", err) + } + if found.Label != "Phone" { + t.Errorf("Label = %q, want %q", found.Label, "Phone") + } +} + +func TestCredentialRepository_FindByIDNotFound(t *testing.T) { + repo := setupCredentialRepo(t) + ctx := context.Background() + + _, err := repo.FindByID(ctx, "nonexistent") + if err != model.ErrNotFound { + t.Fatalf("expected ErrNotFound, got %v", err) + } +} + +func TestCredentialRepository_FindByUserID(t *testing.T) { + repo := setupCredentialRepo(t) + ctx := context.Background() + + c1 := &model.Credential{ID: "c-1", UserID: "user-1", Type: "app_passkey", Label: "A", SecretHash: "h1"} + c2 := &model.Credential{ID: "c-2", UserID: "user-1", Type: "app_passkey", Label: "B", SecretHash: "h2"} + c3 := &model.Credential{ID: "c-3", UserID: "user-2", Type: "app_passkey", Label: "C", SecretHash: "h3"} + + for _, c := range []*model.Credential{c1, c2, c3} { + if err := repo.Create(ctx, c); err != nil { + t.Fatalf("Create = %v", err) + } + } + + creds, err := repo.FindByUserID(ctx, "user-1") + if err != nil { + t.Fatalf("FindByUserID = %v", err) + } + if len(creds) != 2 { + t.Errorf("len(creds) = %d, want 2", len(creds)) + } +} + +func TestCredentialRepository_FindByUserIDAndType(t *testing.T) { + repo := setupCredentialRepo(t) + ctx := context.Background() + + c1 := &model.Credential{ID: "c-1", UserID: "user-1", Type: "app_passkey", Label: "A", SecretHash: "h1"} + c2 := &model.Credential{ID: "c-2", UserID: "user-1", Type: "oauth", Label: "Github", SecretHash: "h2"} + + for _, c := range []*model.Credential{c1, c2} { + if err := repo.Create(ctx, c); err != nil { + t.Fatalf("Create = %v", err) + } + } + + passkeys, err := repo.FindByUserIDAndType(ctx, "user-1", "app_passkey") + if err != nil { + t.Fatalf("FindByUserIDAndType = %v", err) + } + if len(passkeys) != 1 { + t.Errorf("len(passkeys) = %d, want 1", len(passkeys)) + } + if passkeys[0].Type != "app_passkey" { + t.Errorf("type = %q, want %q", passkeys[0].Type, "app_passkey") + } +} + +func TestCredentialRepository_FindByHash(t *testing.T) { + repo := setupCredentialRepo(t) + ctx := context.Background() + + cred := &model.Credential{ID: "c-1", UserID: "user-1", Type: "app_passkey", Label: "Phone", SecretHash: "hash-find"} + if err := repo.Create(ctx, cred); err != nil { + t.Fatalf("Create = %v", err) + } + + found, err := repo.FindByHash(ctx, "hash-find") + if err != nil { + t.Fatalf("FindByHash = %v", err) + } + if found.UserID != "user-1" { + t.Errorf("UserID = %q, want %q", found.UserID, "user-1") + } +} + +func TestCredentialRepository_UpdateLastUsed(t *testing.T) { + repo := setupCredentialRepo(t) + ctx := context.Background() + + cred := &model.Credential{ID: "c-1", UserID: "user-1", Type: "app_passkey", Label: "Phone", SecretHash: "h1"} + if err := repo.Create(ctx, cred); err != nil { + t.Fatalf("Create = %v", err) + } + + if err := repo.UpdateLastUsed(ctx, "c-1"); err != nil { + t.Fatalf("UpdateLastUsed = %v", err) + } + + found, err := repo.FindByID(ctx, "c-1") + if err != nil { + t.Fatalf("FindByID = %v", err) + } + if found.LastUsedAt == nil { + t.Fatal("LastUsedAt should not be nil after update") + } +} + +func TestCredentialRepository_Delete(t *testing.T) { + repo := setupCredentialRepo(t) + ctx := context.Background() + + cred := &model.Credential{ID: "c-1", UserID: "user-1", Type: "app_passkey", Label: "Phone", SecretHash: "h1"} + if err := repo.Create(ctx, cred); err != nil { + t.Fatalf("Create = %v", err) + } + + if err := repo.Delete(ctx, "c-1"); err != nil { + t.Fatalf("Delete = %v", err) + } + + _, err := repo.FindByID(ctx, "c-1") + if err != model.ErrNotFound { + t.Fatalf("expected ErrNotFound after delete, got %v", err) + } +} diff --git a/internal/repository/db.go b/internal/repository/db.go index b2a39a1..b7cfd12 100644 --- a/internal/repository/db.go +++ b/internal/repository/db.go @@ -53,5 +53,6 @@ func AutoMigrate(db *gorm.DB) error { &model.User{}, &model.Session{}, &model.File{}, + &model.Credential{}, ) } diff --git a/internal/server/routes_protected.go b/internal/server/routes_protected.go index 8c25575..35f9e00 100644 --- a/internal/server/routes_protected.go +++ b/internal/server/routes_protected.go @@ -4,9 +4,25 @@ import ( "github.com/gin-gonic/gin" "github.com/dhao2001/mygo/internal/app" + "github.com/dhao2001/mygo/internal/handler" + "github.com/dhao2001/mygo/internal/middleware" ) -func setupProtectedRoutes(rg *gin.RouterGroup, _ *app.WebApp) { - _ = rg - // Protected routes will be registered after auth middleware is implemented. +func setupProtectedRoutes(rg *gin.RouterGroup, webApp *app.WebApp) { + jwtSecret := []byte(webApp.Config.JWT.Secret) + authHandler := handler.NewAuthHandler(webApp.AuthService) + + rg.Use(middleware.AuthRequired(jwtSecret)) + + account := rg.Group("/account") + { + account.GET("", authHandler.GetAccount) + + passkeys := account.Group("/passkeys") + { + passkeys.GET("", authHandler.ListPasskeys) + passkeys.POST("", authHandler.CreatePasskey) + passkeys.DELETE("/:id", authHandler.RevokePasskey) + } + } } diff --git a/internal/server/routes_public.go b/internal/server/routes_public.go index 89260f1..726ba16 100644 --- a/internal/server/routes_public.go +++ b/internal/server/routes_public.go @@ -10,4 +10,13 @@ import ( func setupPublicRoutes(rg *gin.RouterGroup, webApp *app.WebApp) { versionHandler := handler.NewVersionHandler(webApp.Version) rg.GET("/version", versionHandler.Get) + + authHandler := handler.NewAuthHandler(webApp.AuthService) + auth := rg.Group("/auth") + { + auth.POST("/register", authHandler.Register) + auth.POST("/login", authHandler.Login) + auth.POST("/refresh", authHandler.Refresh) + auth.POST("/logout", authHandler.Logout) + } } diff --git a/internal/server/server_test.go b/internal/server/server_test.go index 71a50e6..aef9323 100644 --- a/internal/server/server_test.go +++ b/internal/server/server_test.go @@ -5,13 +5,23 @@ import ( "net/http" "net/http/httptest" "testing" + "time" "github.com/dhao2001/mygo/internal/app" "github.com/dhao2001/mygo/internal/config" + "github.com/dhao2001/mygo/internal/service" ) func TestVersionRoute(t *testing.T) { - webApp := app.NewWebApp(&config.Config{}, nil, nil, nil, nil) + cfg := &config.Config{ + JWT: config.JWTConfig{ + Secret: "test-secret", + AccessTTL: "15m", + RefreshTTL: "168h", + }, + } + authService := service.NewAuthService(nil, nil, nil, nil, 15*time.Minute, 7*24*time.Hour) + webApp := app.NewWebApp(cfg, nil, nil, nil, nil, nil, authService) router := NewRouter(webApp) req := httptest.NewRequest(http.MethodGet, "/api/v1/version", nil) diff --git a/internal/service/auth.go b/internal/service/auth.go new file mode 100644 index 0000000..26b8ec5 --- /dev/null +++ b/internal/service/auth.go @@ -0,0 +1,243 @@ +package service + +import ( + "context" + "errors" + "fmt" + "strings" + "time" + + "github.com/google/uuid" + + "github.com/dhao2001/mygo/internal/auth" + "github.com/dhao2001/mygo/internal/model" + "github.com/dhao2001/mygo/internal/repository" +) + +// TokenPair contains the access and refresh tokens returned after authentication. +type TokenPair struct { + AccessToken string `json:"access_token"` + RefreshToken string `json:"refresh_token"` +} + +// CreatedPasskey contains the raw token for a newly created app passkey. +type CreatedPasskey struct { + ID string `json:"id"` + Raw string `json:"raw"` + Label string `json:"label"` +} + +// AuthService handles user authentication and session management. +type AuthService struct { + userRepo repository.UserRepository + sessionRepo repository.SessionRepository + credentialRepo repository.CredentialRepository + jwtSecret []byte + accessTTL time.Duration + refreshTTL time.Duration +} + +// NewAuthService creates an AuthService. +func NewAuthService( + userRepo repository.UserRepository, + sessionRepo repository.SessionRepository, + credentialRepo repository.CredentialRepository, + jwtSecret []byte, + accessTTL time.Duration, + refreshTTL time.Duration, +) *AuthService { + return &AuthService{ + userRepo: userRepo, + sessionRepo: sessionRepo, + credentialRepo: credentialRepo, + jwtSecret: jwtSecret, + accessTTL: accessTTL, + refreshTTL: refreshTTL, + } +} + +// Register creates a new user account. +func (s *AuthService) Register(ctx context.Context, username, email, password string) (*model.User, error) { + if username == "" || email == "" || password == "" { + return nil, fmt.Errorf("username, email, and password are required") + } + + passwordHash, err := auth.HashPassword(password) + if err != nil { + return nil, fmt.Errorf("hash password: %w", err) + } + + user := &model.User{ + ID: uuid.NewString(), + Username: username, + Email: email, + PasswordHash: passwordHash, + } + + if err := s.userRepo.Create(ctx, user); err != nil { + if errors.Is(err, model.ErrDuplicate) { + return nil, fmt.Errorf("username or email already exists") + } + return nil, fmt.Errorf("create user: %w", err) + } + + return user, nil +} + +// Login authenticates a user by email and password, returning a token pair. +func (s *AuthService) Login(ctx context.Context, email, password string) (*TokenPair, error) { + user, err := s.userRepo.FindByEmail(ctx, email) + if err != nil { + if errors.Is(err, model.ErrNotFound) { + return nil, fmt.Errorf("invalid email or password") + } + return nil, fmt.Errorf("find user: %w", err) + } + + if err := auth.VerifyPassword(user.PasswordHash, password); err != nil { + return nil, fmt.Errorf("invalid email or password") + } + + return s.issueTokens(ctx, user.ID) +} + +// Refresh validates a refresh token and returns a new token pair. +// Each refresh token is single-use: the old session is deleted. +func (s *AuthService) Refresh(ctx context.Context, refreshTokenStr string) (*TokenPair, error) { + claims, err := auth.ParseToken(refreshTokenStr, s.jwtSecret) + if err != nil { + return nil, fmt.Errorf("invalid token") + } + + tokenHash := auth.HashToken(refreshTokenStr) + session, err := s.sessionRepo.FindByTokenHash(ctx, tokenHash) + if err != nil { + if errors.Is(err, model.ErrNotFound) { + return nil, fmt.Errorf("invalid token") + } + return nil, fmt.Errorf("find session: %w", err) + } + + if session.UserID != claims.UserID { + return nil, fmt.Errorf("invalid token") + } + + if err := s.sessionRepo.Delete(ctx, session.ID); err != nil { + return nil, fmt.Errorf("delete old session: %w", err) + } + + return s.issueTokens(ctx, claims.UserID) +} + +// Logout invalidates a refresh token by deleting its session. +func (s *AuthService) Logout(ctx context.Context, refreshTokenStr string) error { + tokenHash := auth.HashToken(refreshTokenStr) + session, err := s.sessionRepo.FindByTokenHash(ctx, tokenHash) + if err != nil { + if errors.Is(err, model.ErrNotFound) { + return nil + } + return fmt.Errorf("find session: %w", err) + } + + return s.sessionRepo.Delete(ctx, session.ID) +} + +// CreatePasskey creates a new app passkey for the authenticated user. +func (s *AuthService) CreatePasskey(ctx context.Context, userID, label string) (*CreatedPasskey, error) { + raw, hash, err := auth.GenerateToken() + if err != nil { + return nil, fmt.Errorf("generate token: %w", err) + } + + cred := &model.Credential{ + ID: uuid.NewString(), + UserID: userID, + Type: "app_passkey", + Label: label, + SecretHash: hash, + } + + if err := s.credentialRepo.Create(ctx, cred); err != nil { + return nil, fmt.Errorf("create credential: %w", err) + } + + return &CreatedPasskey{ + ID: cred.ID, + Raw: raw, + Label: label, + }, nil +} + +// LoginWithPasskey authenticates a user using an app passkey token. +func (s *AuthService) LoginWithPasskey(ctx context.Context, tokenStr string) (*TokenPair, error) { + if !strings.HasPrefix(tokenStr, "mygo_") { + return nil, fmt.Errorf("invalid passkey format") + } + + tokenHash := auth.HashToken(tokenStr) + cred, err := s.credentialRepo.FindByHash(ctx, tokenHash) + if err != nil { + if errors.Is(err, model.ErrNotFound) { + return nil, fmt.Errorf("invalid passkey") + } + return nil, fmt.Errorf("find credential: %w", err) + } + + if cred.Type != "app_passkey" { + return nil, fmt.Errorf("invalid credential type") + } + + if err := s.credentialRepo.UpdateLastUsed(ctx, cred.ID); err != nil { + return nil, fmt.Errorf("update last used: %w", err) + } + + return s.issueTokens(ctx, cred.UserID) +} + +// ListPasskeys returns all app passkeys for a user. +func (s *AuthService) ListPasskeys(ctx context.Context, userID string) ([]model.Credential, error) { + return s.credentialRepo.FindByUserIDAndType(ctx, userID, "app_passkey") +} + +// RevokePasskey deletes an app passkey owned by the user. +func (s *AuthService) RevokePasskey(ctx context.Context, userID, credID string) error { + cred, err := s.credentialRepo.FindByID(ctx, credID) + if err != nil { + return fmt.Errorf("find credential: %w", err) + } + + if cred.UserID != userID { + return model.ErrForbidden + } + + return s.credentialRepo.Delete(ctx, credID) +} + +func (s *AuthService) issueTokens(ctx context.Context, userID string) (*TokenPair, error) { + accessToken, err := auth.GenerateAccessToken(userID, s.jwtSecret, s.accessTTL) + if err != nil { + return nil, fmt.Errorf("generate access token: %w", err) + } + + refreshToken, err := auth.GenerateRefreshToken(userID, s.jwtSecret, s.refreshTTL) + if err != nil { + return nil, fmt.Errorf("generate refresh token: %w", err) + } + + session := &model.Session{ + ID: uuid.NewString(), + UserID: userID, + TokenHash: auth.HashToken(refreshToken), + ExpiresAt: time.Now().Add(s.refreshTTL), + } + + if err := s.sessionRepo.Create(ctx, session); err != nil { + return nil, fmt.Errorf("create session: %w", err) + } + + return &TokenPair{ + AccessToken: accessToken, + RefreshToken: refreshToken, + }, nil +} diff --git a/internal/service/auth_test.go b/internal/service/auth_test.go new file mode 100644 index 0000000..2964e4f --- /dev/null +++ b/internal/service/auth_test.go @@ -0,0 +1,382 @@ +package service + +import ( + "context" + "testing" + "time" + + "gorm.io/driver/sqlite" + "gorm.io/gorm" + + "github.com/dhao2001/mygo/internal/auth" + "github.com/dhao2001/mygo/internal/model" + "github.com/dhao2001/mygo/internal/repository" +) + +func setupAuthService(t *testing.T) *AuthService { + t.Helper() + + db, err := gorm.Open(sqlite.Open(":memory:"), &gorm.Config{}) + if err != nil { + t.Fatalf("open db: %v", err) + } + if err := db.AutoMigrate(&model.User{}, &model.Session{}, &model.Credential{}); err != nil { + t.Fatalf("migrate: %v", err) + } + + userRepo := repository.NewUserRepository(db) + sessionRepo := repository.NewSessionRepository(db) + credentialRepo := repository.NewCredentialRepository(db) + + return NewAuthService( + userRepo, sessionRepo, credentialRepo, + []byte("test-secret"), + 15*time.Minute, + 7*24*time.Hour, + ) +} + +func TestAuthService_Register(t *testing.T) { + svc := setupAuthService(t) + ctx := context.Background() + + user, err := svc.Register(ctx, "alice", "alice@example.com", "password123") + if err != nil { + t.Fatalf("Register = %v", err) + } + if user.ID == "" { + t.Fatal("user ID is empty") + } + if user.Username != "alice" { + t.Errorf("Username = %q, want %q", user.Username, "alice") + } + if user.PasswordHash == "password123" { + t.Fatal("password should be hashed") + } +} + +func TestAuthService_RegisterDuplicate(t *testing.T) { + svc := setupAuthService(t) + ctx := context.Background() + + _, err := svc.Register(ctx, "alice", "alice@example.com", "password123") + if err != nil { + t.Fatalf("Register = %v", err) + } + + _, err = svc.Register(ctx, "alice", "alice2@example.com", "password123") + if err == nil { + t.Fatal("expected error for duplicate username, got nil") + } +} + +func TestAuthService_RegisterEmptyFields(t *testing.T) { + svc := setupAuthService(t) + ctx := context.Background() + + _, err := svc.Register(ctx, "", "alice@example.com", "password") + if err == nil { + t.Fatal("expected error for empty username, got nil") + } +} + +func TestAuthService_Login(t *testing.T) { + svc := setupAuthService(t) + ctx := context.Background() + + _, err := svc.Register(ctx, "alice", "alice@example.com", "password123") + if err != nil { + t.Fatalf("Register = %v", err) + } + + pair, err := svc.Login(ctx, "alice@example.com", "password123") + if err != nil { + t.Fatalf("Login = %v", err) + } + if pair.AccessToken == "" { + t.Fatal("access token is empty") + } + if pair.RefreshToken == "" { + t.Fatal("refresh token is empty") + } +} + +func TestAuthService_LoginWrongPassword(t *testing.T) { + svc := setupAuthService(t) + ctx := context.Background() + + _, err := svc.Register(ctx, "alice", "alice@example.com", "password123") + if err != nil { + t.Fatalf("Register = %v", err) + } + + _, err = svc.Login(ctx, "alice@example.com", "wrongpassword") + if err == nil { + t.Fatal("expected error for wrong password, got nil") + } +} + +func TestAuthService_LoginNonexistentEmail(t *testing.T) { + svc := setupAuthService(t) + ctx := context.Background() + + _, err := svc.Login(ctx, "nonexistent@example.com", "password") + if err == nil { + t.Fatal("expected error for nonexistent email, got nil") + } +} + +func TestAuthService_Refresh(t *testing.T) { + svc := setupAuthService(t) + ctx := context.Background() + + _, err := svc.Register(ctx, "alice", "alice@example.com", "password123") + if err != nil { + t.Fatalf("Register = %v", err) + } + + pair, err := svc.Login(ctx, "alice@example.com", "password123") + if err != nil { + t.Fatalf("Login = %v", err) + } + + newPair, err := svc.Refresh(ctx, pair.RefreshToken) + if err != nil { + t.Fatalf("Refresh = %v", err) + } + if newPair.AccessToken == "" { + t.Fatal("new access token is empty") + } + if newPair.RefreshToken == "" { + t.Fatal("new refresh token is empty") + } + if newPair.RefreshToken == pair.RefreshToken { + t.Fatal("refresh token should be rotated") + } +} + +func TestAuthService_RefreshSingleUse(t *testing.T) { + svc := setupAuthService(t) + ctx := context.Background() + + _, err := svc.Register(ctx, "alice", "alice@example.com", "password123") + if err != nil { + t.Fatalf("Register = %v", err) + } + + pair, err := svc.Login(ctx, "alice@example.com", "password123") + if err != nil { + t.Fatalf("Login = %v", err) + } + + _, err = svc.Refresh(ctx, pair.RefreshToken) + if err != nil { + t.Fatalf("first Refresh = %v", err) + } + + _, err = svc.Refresh(ctx, pair.RefreshToken) + if err == nil { + t.Fatal("second refresh with same token should fail") + } +} + +func TestAuthService_Logout(t *testing.T) { + svc := setupAuthService(t) + ctx := context.Background() + + _, err := svc.Register(ctx, "alice", "alice@example.com", "password123") + if err != nil { + t.Fatalf("Register = %v", err) + } + + pair, err := svc.Login(ctx, "alice@example.com", "password123") + if err != nil { + t.Fatalf("Login = %v", err) + } + + if err := svc.Logout(ctx, pair.RefreshToken); err != nil { + t.Fatalf("Logout = %v", err) + } + + _, err = svc.Refresh(ctx, pair.RefreshToken) + if err == nil { + t.Fatal("refresh should fail after logout") + } +} + +func TestAuthService_CreatePasskey(t *testing.T) { + svc := setupAuthService(t) + ctx := context.Background() + + _, err := svc.Register(ctx, "alice", "alice@example.com", "password123") + if err != nil { + t.Fatalf("Register = %v", err) + } + + pair, err := svc.Login(ctx, "alice@example.com", "password123") + if err != nil { + t.Fatalf("Login = %v", err) + } + + // Extract userID from access token + claims, err := auth.ParseToken(pair.AccessToken, []byte("test-secret")) + if err != nil { + t.Fatalf("ParseToken = %v", err) + } + // Import auth for claims access + // Already using auth above + + pk, err := svc.CreatePasskey(ctx, claims.UserID, "My Phone") + if err != nil { + t.Fatalf("CreatePasskey = %v", err) + } + if pk.ID == "" { + t.Fatal("passkey ID is empty") + } + if pk.Raw == "" { + t.Fatal("raw token is empty") + } + if pk.Label != "My Phone" { + t.Errorf("Label = %q, want %q", pk.Label, "My Phone") + } +} + +func TestAuthService_LoginWithPasskey(t *testing.T) { + svc := setupAuthService(t) + ctx := context.Background() + + _, err := svc.Register(ctx, "alice", "alice@example.com", "password123") + if err != nil { + t.Fatalf("Register = %v", err) + } + + pair, err := svc.Login(ctx, "alice@example.com", "password123") + if err != nil { + t.Fatalf("Login = %v", err) + } + + claims, err := auth.ParseToken(pair.AccessToken, []byte("test-secret")) + if err != nil { + t.Fatalf("ParseToken = %v", err) + } + + pk, err := svc.CreatePasskey(ctx, claims.UserID, "My Phone") + if err != nil { + t.Fatalf("CreatePasskey = %v", err) + } + + loginPair, err := svc.LoginWithPasskey(ctx, pk.Raw) + if err != nil { + t.Fatalf("LoginWithPasskey = %v", err) + } + if loginPair.AccessToken == "" { + t.Fatal("access token is empty") + } +} + +func TestAuthService_LoginWithPasskeyInvalidFormat(t *testing.T) { + svc := setupAuthService(t) + ctx := context.Background() + + _, err := svc.LoginWithPasskey(ctx, "not-a-mygo-token") + if err == nil { + t.Fatal("expected error for invalid passkey format, got nil") + } +} + +func TestAuthService_RevokePasskey(t *testing.T) { + svc := setupAuthService(t) + ctx := context.Background() + + _, err := svc.Register(ctx, "alice", "alice@example.com", "password123") + if err != nil { + t.Fatalf("Register = %v", err) + } + + pair, _ := svc.Login(ctx, "alice@example.com", "password123") + claims, _ := auth.ParseToken(pair.AccessToken, []byte("test-secret")) + + pk, err := svc.CreatePasskey(ctx, claims.UserID, "My Phone") + if err != nil { + t.Fatalf("CreatePasskey = %v", err) + } + + if err := svc.RevokePasskey(ctx, claims.UserID, pk.ID); err != nil { + t.Fatalf("RevokePasskey = %v", err) + } + + _, err = svc.LoginWithPasskey(ctx, pk.Raw) + if err == nil { + t.Fatal("login with revoked passkey should fail") + } +} + +func TestAuthService_RevokePasskeyNotOwner(t *testing.T) { + svc := setupAuthService(t) + ctx := context.Background() + + _, err := svc.Register(ctx, "alice", "alice@example.com", "password123") + if err != nil { + t.Fatalf("Register = %v", err) + } + _, err = svc.Register(ctx, "bob", "bob@example.com", "password456") + if err != nil { + t.Fatalf("Register = %v", err) + } + + pair, _ := svc.Login(ctx, "alice@example.com", "password123") + claims, _ := auth.ParseToken(pair.AccessToken, []byte("test-secret")) + + pk, err := svc.CreatePasskey(ctx, claims.UserID, "My Phone") + if err != nil { + t.Fatalf("CreatePasskey = %v", err) + } + + pairBob, _ := svc.Login(ctx, "bob@example.com", "password456") + claimsBob, _ := auth.ParseToken(pairBob.AccessToken, []byte("test-secret")) + + err = svc.RevokePasskey(ctx, claimsBob.UserID, pk.ID) + if err != model.ErrForbidden { + t.Fatalf("expected ErrForbidden, got %v", err) + } +} + +func TestAuthService_ListPasskeys(t *testing.T) { + svc := setupAuthService(t) + ctx := context.Background() + + _, err := svc.Register(ctx, "alice", "alice@example.com", "password123") + if err != nil { + t.Fatalf("Register = %v", err) + } + + pair, _ := svc.Login(ctx, "alice@example.com", "password123") + claims, _ := auth.ParseToken(pair.AccessToken, []byte("test-secret")) + + _, err = svc.CreatePasskey(ctx, claims.UserID, "Phone") + if err != nil { + t.Fatalf("CreatePasskey 1 = %v", err) + } + _, err = svc.CreatePasskey(ctx, claims.UserID, "Laptop") + if err != nil { + t.Fatalf("CreatePasskey 2 = %v", err) + } + + passkeys, err := svc.ListPasskeys(ctx, claims.UserID) + if err != nil { + t.Fatalf("ListPasskeys = %v", err) + } + if len(passkeys) != 2 { + t.Errorf("len(passkeys) = %d, want 2", len(passkeys)) + } +} + +func TestAuthService_RefreshWithInvalidToken(t *testing.T) { + svc := setupAuthService(t) + ctx := context.Background() + + _, err := svc.Refresh(ctx, "not-a-valid-token") + if err == nil { + t.Fatal("expected error for invalid refresh token, got nil") + } +}