MyGO/mygo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(repository): refactor query/mutation ports with capability-safe

Browse Source 
interfaces

- refactor: split UserRepository into AuthUserRepository and
  AdminUserRepository capabilities
- refactor: split SessionRepository into AuthSessionRepository and
  repository-owned CLI/admin methods
- refactor: replace generic Repository Update/Delete with
  operation-specific params and ownership predicates
- refactor: replace CredentialRepository generic CRUD with
  passkey-specific methods
- refactor: replace FileRepository generic Create/Update/Delete with
  UploadedFileParams, DirectoryParams, and owned soft-delete
- refactor: remove repository fields from WebApp struct; repositories
  are now composition-time wiring only
- feat: add domain error kinds ErrParentNotFound, ErrParentNotDir,
  ErrDirectoryNotEmpty, ErrInvalidMove
- feat: add CredentialTypeAppPasskey constant
- feat: add testutil.SetUserAdmin for test fixture setup that bypasses
  production service ports
- test: add architecture test banning GORM Save in repository package
- test: add capability interface contract tests ensuring each service
  receives the minimal interface
- test: add blockingStorage helper for concurrent promotion tests
- test: add preserved DSN parameter test for sqliteImmediateDSN
- docs: update architecture decisions with repository write rules and
  capability separation
- docs: update roadmap to clarify atomic single-use refresh sessions
- docs: add -race test target to development docs
This commit is contained in:
Sunday
2026-07-16 12:24:36 +08:00
parent 6604ecb026
commit a18f96912d
30 changed files with 1259 additions and 394 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/repository/session_test.go
+79 -13
View File
@@ -2,12 +2,16 @@ package repository
import (
"context"
"errors"
"path/filepath"
"sync"
"testing"
"time"
"gorm.io/driver/sqlite"
"gorm.io/gorm"
"github.com/dhao2001/mygo/internal/config"
"github.com/dhao2001/mygo/internal/model"
)
@@ -25,6 +29,12 @@ func setupSessionRepo(t *testing.T) SessionRepository {
return NewSessionRepository(db)
}
func createSessionRecord(ctx context.Context, repo SessionRepository, session *model.Session) error {
return repo.CreateRefreshSession(ctx, RefreshSessionParams{
ID: session.ID, UserID: session.UserID, TokenHash: session.TokenHash, ExpiresAt: session.ExpiresAt,
})
}
func TestSessionRepository_Create(t *testing.T) {
repo := setupSessionRepo(t)
ctx := context.Background()
@@ -36,7 +46,7 @@ func TestSessionRepository_Create(t *testing.T) {
ExpiresAt: time.Now().Add(24 * time.Hour),
}
if err := repo.Create(ctx, session); err != nil {
if err := createSessionRecord(ctx, repo, session); err != nil {
t.Fatalf("Create = %v", err)
}
}
@@ -48,11 +58,11 @@ func TestSessionRepository_CreateDuplicateHash(t *testing.T) {
s1 := &model.Session{ID: "session-1", UserID: "user-1", TokenHash: "hash-abc", ExpiresAt: time.Now().Add(24 * time.Hour)}
s2 := &model.Session{ID: "session-2", UserID: "user-2", TokenHash: "hash-abc", ExpiresAt: time.Now().Add(24 * time.Hour)}
if err := repo.Create(ctx, s1); err != nil {
if err := createSessionRecord(ctx, repo, s1); err != nil {
t.Fatalf("Create = %v", err)
}
err := repo.Create(ctx, s2)
err := createSessionRecord(ctx, repo, s2)
if err != model.ErrDuplicate {
t.Fatalf("expected ErrDuplicate, got %v", err)
}
@@ -63,7 +73,7 @@ func TestSessionRepository_FindByID(t *testing.T) {
ctx := context.Background()
session := &model.Session{ID: "session-1", UserID: "user-1", TokenHash: "hash-abc", ExpiresAt: time.Now().Add(24 * time.Hour)}
if err := repo.Create(ctx, session); err != nil {
if err := createSessionRecord(ctx, repo, session); err != nil {
t.Fatalf("Create = %v", err)
}
@@ -81,7 +91,7 @@ func TestSessionRepository_FindByTokenHash(t *testing.T) {
ctx := context.Background()
session := &model.Session{ID: "session-1", UserID: "user-1", TokenHash: "hash-abc", ExpiresAt: time.Now().Add(24 * time.Hour)}
if err := repo.Create(ctx, session); err != nil {
if err := createSessionRecord(ctx, repo, session); err != nil {
t.Fatalf("Create = %v", err)
}
@@ -109,15 +119,19 @@ func TestSessionRepository_Delete(t *testing.T) {
ctx := context.Background()
session := &model.Session{ID: "session-1", UserID: "user-1", TokenHash: "hash-abc", ExpiresAt: time.Now().Add(24 * time.Hour)}
if err := repo.Create(ctx, session); err != nil {
if err := createSessionRecord(ctx, repo, session); err != nil {
t.Fatalf("Create = %v", err)
}
if err := repo.Delete(ctx, "session-1"); err != nil {
t.Fatalf("Delete = %v", err)
consumed, err := repo.ConsumeRefreshSession(ctx, "hash-abc")
if err != nil {
t.Fatalf("ConsumeRefreshSession = %v", err)
}
if consumed.ID != "session-1" {
t.Fatalf("consumed ID = %q, want session-1", consumed.ID)
}
_, err := repo.FindByID(ctx, "session-1")
_, err = repo.FindByID(ctx, "session-1")
if err != model.ErrNotFound {
t.Fatalf("expected ErrNotFound after delete, got %v", err)
}
@@ -132,12 +146,12 @@ func TestSessionRepository_DeleteByUserID(t *testing.T) {
s3 := &model.Session{ID: "session-3", UserID: "user-2", TokenHash: "hash-3", ExpiresAt: time.Now().Add(24 * time.Hour)}
for _, s := range []*model.Session{s1, s2, s3} {
if err := repo.Create(ctx, s); err != nil {
if err := createSessionRecord(ctx, repo, s); err != nil {
t.Fatalf("Create = %v", err)
}
}
if err := repo.DeleteByUserID(ctx, "user-1"); err != nil {
if err := repo.DeleteSessionsByUserID(ctx, "user-1"); err != nil {
t.Fatalf("DeleteByUserID = %v", err)
}
@@ -168,12 +182,12 @@ func TestSessionRepository_DeleteExpired(t *testing.T) {
}
for _, s := range []*model.Session{expired, valid} {
if err := repo.Create(ctx, s); err != nil {
if err := createSessionRecord(ctx, repo, s); err != nil {
t.Fatalf("Create = %v", err)
}
}
count, err := repo.DeleteExpired(ctx)
count, err := repo.DeleteExpiredSessions(ctx)
if err != nil {
t.Fatalf("DeleteExpired = %v", err)
}
@@ -188,3 +202,55 @@ func TestSessionRepository_DeleteExpired(t *testing.T) {
t.Fatalf("valid session should still exist: %v", err)
}
}
func TestSessionRepository_ConsumeRefreshSessionIsAtomic(t *testing.T) {
db, err := Open(config.DatabaseConfig{
Driver: "sqlite3",
SQLite: config.SQLiteConfig{Path: filepath.Join(t.TempDir(), "sessions.db")},
})
if err != nil {
t.Fatalf("open db: %v", err)
}
if err := AutoMigrate(db); err != nil {
t.Fatalf("migrate: %v", err)
}
repo := NewSessionRepository(db)
ctx := context.Background()
if err := repo.CreateRefreshSession(ctx, RefreshSessionParams{
ID: "session-1", UserID: "user-1", TokenHash: "single-use", ExpiresAt: time.Now().Add(time.Hour),
}); err != nil {
t.Fatalf("CreateRefreshSession = %v", err)
}
start := make(chan struct{})
results := make(chan error, 2)
var wg sync.WaitGroup
wg.Add(2)
for range 2 {
go func() {
defer wg.Done()
<-start
_, err := repo.ConsumeRefreshSession(ctx, "single-use")
results <- err
}()
}
close(start)
wg.Wait()
close(results)
succeeded := 0
notFound := 0
for err := range results {
switch {
case err == nil:
succeeded++
case errors.Is(err, model.ErrNotFound):
notFound++
default:
t.Fatalf("ConsumeRefreshSession unexpected error: %v", err)
}
}
if succeeded != 1 || notFound != 1 {
t.Fatalf("consume results: success=%d not_found=%d, want 1 each", succeeded, notFound)
}
}