skill: refine repo-review skill instructions for clarity and calibration
This commit is contained in:
@@ -22,6 +22,8 @@ Use these severity levels independently of category:
|
||||
|
||||
Sort findings by severity, then by impact within the same severity. Security is a category, not a severity; a security finding can have any severity.
|
||||
|
||||
Make each `Analysis` identify the existing behavior, boundary, or invariant under review, the evidence and reachable violation path, and the material impact. Do not use any report section as a backlog for absent WIP, planned, or future capabilities.
|
||||
|
||||
Use this structure:
|
||||
|
||||
```markdown
|
||||
@@ -34,19 +36,22 @@ Use this structure:
|
||||
|
||||
- Findings
|
||||
- ID: <CATEGORY-NNN>
|
||||
- Severity: Critical | High | Medium | Low
|
||||
- Location: <filename:line>
|
||||
- Analysis: <evidence, reachable causal path, and material impact>
|
||||
- Recommendation: <root-cause repair direction>
|
||||
- Severity: Critical | High | Medium | Low
|
||||
- Location: <filename:line>
|
||||
- Analysis: <existing behavior or invariant, evidence and reachable violation path, and material impact>
|
||||
- Recommendation: <root-cause repair direction>
|
||||
|
||||
- ID: <CATEGORY-NNN>
|
||||
- <same as above>
|
||||
|
||||
- Architecture drift
|
||||
- <material differences between documented and implemented architecture, referencing finding IDs instead of duplicating analysis>
|
||||
- <material current differences between documented and implemented architecture, referencing finding IDs instead of duplicating analysis>
|
||||
|
||||
- Documentation drift
|
||||
- <documentation inaccuracies that can materially mislead implementation, operation, or review>
|
||||
|
||||
- Unverified areas
|
||||
- <unverified area, reason, and required validation>
|
||||
- <near-qualifying current defect, missing fact, and the specific validation needed>
|
||||
```
|
||||
|
||||
If there are no qualifying findings, write `Findings: None`. Write `None` for any other empty section. Do not omit verification failures or review limitations.
|
||||
|
||||
Reference in New Issue
Block a user