Updated plugins

sources_non_forked/vim-go/autoload/go/rename.vim

@@ -6,22 +6,22 @@ if !exists("g:go_gorename_prefill")
   let g:go_gorename_prefill = 1
 endif
 
-function! go#rename#Rename(bang, ...)
-  let to = ""
+function! go#rename#Rename(bang, ...) abort
+  let to_identifier = ""
   if a:0 == 0
     let from = expand("<cword>")
     let ask = printf("vim-go: rename '%s' to: ", from)
     if g:go_gorename_prefill
-      let to = input(ask, from)
+      let to_identifier = input(ask, from)
     else
-      let to = input(ask)
+      let to_identifier = input(ask)
     endif
     redraw!
-    if empty(to)
+    if empty(to_identifier)
       return
     endif
   else
-    let to = a:1
+    let to_identifier = a:1
   endif
 
   "return with a warning if the bin doesn't exist
@@ -32,10 +32,79 @@ function! go#rename#Rename(bang, ...)
 
   let fname = expand('%:p')
   let pos = go#util#OffsetCursor()
-  let cmd = printf('%s -offset %s -to %s', shellescape(bin_path), shellescape(printf('%s:#%d', fname, pos)), shellescape(to))
+  let offset = printf('%s:#%d', fname, pos)
 
-  let out = go#tool#ExecuteInDir(cmd)
+  " no need to escape for job call
+  let bin_path = go#util#has_job() ? bin_path : shellescape(bin_path)
+  let offset = go#util#has_job() ? offset : shellescape(offset)
+  let to_identifier = go#util#has_job() ? to_identifier : shellescape(to_identifier)
 
+  let cmd = [bin_path, "-offset", offset, "-to", to_identifier]
+
+  if go#util#has_job()
+    call go#util#EchoProgress(printf("renaming to '%s' ...", to_identifier))
+    call s:rename_job({
+          \ 'cmd': cmd,
+          \ 'bang': a:bang,
+          \})
+    return
+  endif
+
+  let command = join(cmd, " ")
+  let out = go#tool#ExecuteInDir(command)
+
+  let splitted = split(out, '\n')
+  call s:parse_errors(go#util#ShellError(), a:bang, splitted)
+endfunction
+
+function s:rename_job(args)
+  let messages = []
+  function! s:callback(chan, msg) closure
+    call add(messages, a:msg)
+  endfunction
+
+  let status_dir =  expand('%:p:h')
+
+  function! s:close_cb(chan) closure
+    let l:job = ch_getjob(a:chan)
+    let l:info = job_info(l:job)
+
+    let status = {
+          \ 'desc': 'last status',
+          \ 'type': "gorename",
+          \ 'state': "finished",
+          \ }
+
+    if l:info.exitval
+      let status.state = "failed"
+    endif
+
+    call go#statusline#Update(status_dir, status)
+
+    call s:parse_errors(l:info.exitval, a:args.bang, messages)
+  endfunction
+
+  let start_options = {
+        \ 'callback': function("s:callback"),
+        \ 'close_cb': function("s:close_cb"),
+        \ }
+
+  " modify GOPATH if needed
+  let old_gopath = $GOPATH
+  let $GOPATH = go#path#Detect()
+
+  call go#statusline#Update(status_dir, {
+        \ 'desc': "current status",
+        \ 'type': "gorename",
+        \ 'state': "started",
+        \})
+
+  call job_start(a:args.cmd, start_options)
+
+  let $GOPATH = old_gopath
+endfunction
+
+function s:parse_errors(exit_val, bang, out)
   " reload all files to reflect the new changes. We explicitly call
   " checktime to trigger a reload of all files. See
   " http://www.mail-archive.com/vim@vim.org/msg05900.html for more info
@@ -45,28 +114,28 @@ function! go#rename#Rename(bang, ...)
   silent! checktime
   let &autoread = current_autoread
 
-  " strip out newline on the end that gorename puts. If we don't remove, it
-  " will trigger the 'Hit ENTER to continue' prompt
-  let clean = split(out, '\n')
-
   let l:listtype = "quickfix"
-  if go#util#ShellError() != 0
-    let errors = go#tool#ParseErrors(split(out, '\n'))
-    call go#list#Populate(l:listtype, errors)
+  if a:exit_val != 0
+    call go#util#EchoError("FAILED")
+    let errors = go#tool#ParseErrors(a:out)
+    call go#list#Populate(l:listtype, errors, 'Rename')
     call go#list#Window(l:listtype, len(errors))
     if !empty(errors) && !a:bang
       call go#list#JumpToFirst(l:listtype)
     elseif empty(errors)
       " failed to parse errors, output the original content
-      call go#util#EchoError(out)
+      call go#util#EchoError(join(a:out, ""))
     endif
+
     return
-  else
-    call go#list#Clean(l:listtype)
-    call go#list#Window(l:listtype)
-    redraw | echon "vim-go: " | echohl Function | echon clean[0] | echohl None
   endif
 
+  " strip out newline on the end that gorename puts. If we don't remove, it
+  " will trigger the 'Hit ENTER to continue' prompt
+  call go#list#Clean(l:listtype)
+  call go#list#Window(l:listtype)
+  call go#util#EchoSuccess(a:out[0])
+
   " refresh the buffer so we can see the new content
   " TODO(arslan): also find all other buffers and refresh them too. For this
   " we need a way to get the list of changes from gorename upon an success